bsp version control

[MadGypsy]

(('B' << 0) | ('S' << | ('P' << 16) | ('2'<<24))

I can't do that in HaXe. HaXe expects those string literals to be ints.

I googled "c++ bitshift string literals" and other such things but, I can't find anything that tells me what type of int value those characters are perceived as.

Is it Oct? Dec? Hex? Something Else?

When I get past this little baby hump I should be able to parse 2PSB, BSP & BSP2. I already made all of the other necessary changes.

[Spike]

Its ascii...

BSP=29 (vanilla)
2PSB=0x42535032 (node+leaf bounds are still shorts, all other shorts expanded to int)
BSP2=0x32505342 (node+leaf bounds are floats, all other shorts expanded to int)

[Baker]

Protip: Those aren't string literals!

'B' is a number with the value of 66 (like how 'A' = 65 in ascii)

int a = 'B'; // a is now 66

[MadGypsy]

thank you both

@string literals

I didn't know how else to describe it. I knew they weren't shifting "BSP2".

@all shorts ints

nope... not marksurfaces... Well, according to bspfile.h in Fitzquake Mark V r15. I based my structs on that file.

[Spike]

'B' would normally be referred to as a character constant.

and they're ints, not shorts.

[MadGypsy]

@char constant

Ah! I forgot about that term. I don't think any of the languages that I know allow for them, at least not with the string literal syntax.

aside:
I'm about 80% of the way through porting my AS3 engine to HaXe. I've been using numerous quake sources to develop this version. The BSP part of my engine should function more or less identical to an advanced quake engine. I don't intend to post much about it til I get quite a bit further but, I wanted you guys to know that I never threw in the towel on my quakelike engine. I just needed some time to learn another language and nail down a fairly solid understanding of C(whatever) in a "fundamentals" regard. I'm more or less reading quake sources without any real questions...at least no questions that I can't figure out on my own, so far. HaXe is more or less what would happen if AS3 and C(probably ++) had a baby so, reading C(whatever) is getting easier all the time.

[MadGypsy]

@ints not shorts

to be clear you are saying this is wrong?

[Spike]

that bss abuse would never fit within quake's dos 8mb ram target.
the '#ifndef QUAKE_GAME' means that its not used for the engine - its dead code.

there's also none of the bsp2 struct defs there either.
with bsp29, marksurfaces is shorts. with bsp2, either kind, its ints.

[MadGypsy]

@no bsp2 structs there

The non bsp29 structs are all higher up on the document but, marksurfaces does not have a version specific struct anywhere in the entire document. It's all good, I made sure my structs match what you said.

My method makes adding these versions really simple. 2PSB extends BSP29 and overrides accordingly...BSP2 extends 2PSB and overrides readNodes/Leafs. I figured since the enhanced versions are just a modification of the version before it, extending and overriding the specifics made the most sense. Everything gets unified to BSP_t and at that point it really doesn't matter what version it was.

Haxe doesn't differentiate types as accurately as short/long/int* within a struct so, the only thing I really had to do was replace BBoxShort_t with BBox_t for all versions. I simply read short/int into the expected float values accordingly and I don't have to create any custom structs per version.

*this would all just be Int